You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/08 22:22:38 UTC
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18603
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
IMPALA-11343: Override isOpen to avoid thrift bug
Overrides isOpen on TSSLSocket to work around THRIFT-5595.
Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
---
M shell/TSSLSocketWithWildcardSAN.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/18603/1
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10740/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 22:42:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8218/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 20:53:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8217/
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 20:46:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8206/
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jun 2022 03:40:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Jun 2022 01:38:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8217/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jun 2022 16:08:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8206/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 22:44:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 16:28:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11343: Override isOpen to avoid thrift bug
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18603 )
Change subject: IMPALA-11343: Override isOpen to avoid thrift bug
......................................................................
IMPALA-11343: Override isOpen to avoid thrift bug
Overrides isOpen on TSSLSocket to work around THRIFT-5595.
Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Reviewed-on: http://gerrit.cloudera.org:8080/18603
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M shell/TSSLSocketWithWildcardSAN.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18603
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff9dfb3aaf578a7dbcedd3ca8e1478a5ecb958c3
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>