[jira] [Commented] (ROCKETMQ-96) Rename tmp variable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906866#comment-15906866 ] 

ASF GitHub Bot commented on ROCKETMQ-96:
----------------------------------------

Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/60
  
    @zhouxinyu @shroman @vongosling @lizhanhui 
    Guys, how do you think of this pr, which does not change any functionality , I just rename some variables/fields to make code more readable.
    



> Rename tmp variable 
> --------------------
>
>                 Key: ROCKETMQ-96
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-96
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-client
>    Affects Versions: 4.0.0-incubating
>            Reporter: Jaskey Lam
>            Assignee: Jaskey Lam
>            Priority: Minor
>
> Some variable is named with tmp which is very difficult to read and understand its usage.
> For exampe:
> 1. in sendDefaultImpl, when select message queue, the variable is named with 
>     
>       MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, lastBrokerName);
> 2. In process queue, a field is named `msgTreeMapTemp`, which takes me minutes to understand why it is desgined for, which should be rename to some name like consumeingOrderlyMsgTreeMap



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)