You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Matt Ryan (Jira)" <ji...@apache.org> on 2020/03/24 22:01:00 UTC

[jira] [Commented] (OAK-8969) Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set

    [ https://issues.apache.org/jira/browse/OAK-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066218#comment-17066218 ] 

Matt Ryan commented on OAK-8969:
--------------------------------

If caching is enabled then there is a chance that a URI previously generated without ignoring a domain override will be reused out of cache when another URI for the same blob ID is requested again.  If the subsequent request wants to ignore the domain override then the wrong URI will then be pulled from the cache, if the URI hasn't expired yet, because the key for the cache is just the blob ID.

A simple solution to this would be to compute the value of the download URI domain beforehand, and then use that along with the blob ID for the cache key.  The domain value will be different if the domain override ignore flag is set than it would be if it is not set, so this would result in a cache miss and the correct URI being returned.

> Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set
> ------------------------------------------------------------------------------------------
>
>                 Key: OAK-8969
>                 URL: https://issues.apache.org/jira/browse/OAK-8969
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob-cloud
>            Reporter: Jun Zhang
>            Assignee: Matt Ryan
>            Priority: Major
>
> Ignore domain overwrite doesn't work well when presignedHttpDownloadURICacheMaxSize is set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)