You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/10/28 07:53:58 UTC

[GitHub] [rocketmq-spring] vongosling commented on a change in pull request #129: [ISSUE #103] support resolvePlaceholders for selectorExpression

vongosling commented on a change in pull request #129: [ISSUE #103]  support resolvePlaceholders for selectorExpression
URL: https://github.com/apache/rocketmq-spring/pull/129#discussion_r339432396
 
 

 ##########
 File path: rocketmq-spring-boot/src/test/java/org/apache/rocketmq/spring/autoconfigure/RocketMQAutoConfigurationTest.java
 ##########
 @@ -272,5 +293,24 @@ public RocketMQTemplate extRocketMQTemplate() {
     static class MyExtRocketMQTemplate extends RocketMQTemplate {
 
 Review comment:
   Could you modify the class MyExtRocketMQTemplate name, you could assign a concrete name Instead of a name with no actual meaning my**?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services