You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/12/01 18:36:46 UTC
Re: Review Request 28484: Rename Socket read to recv. This is more
consistent: send/recv vs. send/read.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28484/#review63382
-----------------------------------------------------------
Ship it!
Ship It!
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/28484/#comment105625>
it sure would be nice if these were unique_ptrs passed in with ownership so the scope was automatically managed.
*HINT*
- Dominic Hamon
On Nov. 27, 2014, 10:35 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28484/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 10:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
>
> Diff: https://reviews.apache.org/r/28484/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>