[jira] [Commented] (STORM-1779) Incorrect bfs-ordering in DefaultResourceAwareStrategy

["Boyang Jerry Peng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280494#comment-15280494 ] 

Boyang Jerry Peng commented on STORM-1779:
------------------------------------------

dup of https://issues.apache.org/jira/browse/STORM-1681.  Already fixed in master-security as well as 1.x branch

> Incorrect bfs-ordering in DefaultResourceAwareStrategy
> ------------------------------------------------------
>
>                 Key: STORM-1779
>                 URL: https://issues.apache.org/jira/browse/STORM-1779
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 1.0.0
>            Reporter: Pavel Smirnov
>            Priority: Minor
>              Labels: bug, scheduler
>
> I have designed a simple diamond topology: spout, N parallel processingBolts, joinBolt.
> https://github.com/smirnp/storm-benchmark/blob/1.0.0/src/storm/benchmark/DiamondTopology.java
> For 6-components topopoly the breadth-first search (bfs method in DefaultResourceAwareStrategy.java:323) returns 13 components, which is obviously incorrect for further scheduling (it fails on memory limits trying to schedule already scheduled tasks in priorityToExecutorMap). 
> I have reimplemented bfs with the comparison with the original-one (https://github.com/smirnp/storm-benchmark/blob/1.0.0/bfs.txt) 
> Please check it and fix the bug in next releases.
> P.S. storm.yaml user for scheduling is here: 
> https://github.com/smirnp/storm-benchmark/blob/1.0.0/storm.yaml
> Best regards,
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)