You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/10 21:36:53 UTC

[GitHub] [arrow-rs] felixonmars opened a new pull request #769: Fix riscv64 target_arch

felixonmars opened a new pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769


   This should be defined for riscv64 instead, as `riscv` doesn't match it.
   I have no idea for riscv32 though.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] felixonmars commented on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
felixonmars commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-920271544


   > So I also didn't see `riscv64` as a supported architecture. The supported architectures from my `rustc` (1.55) are:
   
   The first part of the triplet isn't the same as `target_arch`, which I think is from LLVM.
   
   You can see that rustc itself uses the same value here:
   https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/src/test/ui/cfg/conditional-compile-arch.rs#L40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb merged pull request #769: Add support for riscv64

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] codecov-commenter commented on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-917341933


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#769](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c60ff62) into [master](https://codecov.io/gh/apache/arrow-rs/commit/2f78c7abb30589bdd05d9d7caecb2edbbfae3066?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f78c7a) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/769/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #769   +/-   ##
   =======================================
     Coverage   82.51%   82.51%           
   =======================================
     Files         168      168           
     Lines       47831    47831           
   =======================================
     Hits        39470    39470           
     Misses       8361     8361           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f78c7a...c60ff62](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb commented on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-917618594


   Thank you for the contribution @felixonmars 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-917341933


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#769](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12e15a6) into [master](https://codecov.io/gh/apache/arrow-rs/commit/2f78c7abb30589bdd05d9d7caecb2edbbfae3066?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f78c7a) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/769/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #769      +/-   ##
   ==========================================
   + Coverage   82.51%   82.54%   +0.02%     
   ==========================================
     Files         168      168              
     Lines       47831    47913      +82     
   ==========================================
   + Hits        39470    39552      +82     
     Misses       8361     8361              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [parquet/src/util/hash\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvdXRpbC9oYXNoX3V0aWwucnM=) | `95.77% <ø> (ø)` | |
   | [parquet/src/record/api.rs](https://codecov.io/gh/apache/arrow-rs/pull/769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvcmVjb3JkL2FwaS5ycw==) | `91.60% <0.00%> (ø)` | |
   | [arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow-rs/pull/769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3JlY29yZF9iYXRjaC5ycw==) | `92.65% <0.00%> (+2.21%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f78c7a...12e15a6](https://codecov.io/gh/apache/arrow-rs/pull/769?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb edited a comment on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-921229364


   @felixonmars  what command are you using to compile against `riscv64` (in other words how would I test this PR)? 
   
   When I tried to run 
   ```
   cargo build --target riscv64
   cargo build --target riscv64
   error: failed to run `rustc` to learn about target-specific information
   ```
   
   I am sorry for my ignorance here -- I don't have access to a machine with such an architecture and haven't tried cross compiling myself. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] felixonmars commented on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
felixonmars commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-921257414


   > @felixonmars what command are you using to compile against `riscv64` (in other words how would I test this PR)?
   
   I am building natively with qemu-user and also on a real riscv64 hardware (HiFive Unmatched). All tests are passing here, too.
   
   You probably need to specify the full triplet to cross compile: `cargo build --target riscv64gc-unknown-linux-gnu`, and I don't know if it's going to work....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb commented on a change in pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#discussion_r706823582



##########
File path: arrow/src/alloc/alignment.rs
##########
@@ -62,7 +62,7 @@ pub const ALIGNMENT: usize = 1 << 6;
 // - https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/riscv/sifive-l2-cache.txt#L41
 // in general all of them are the same.
 /// Cache and allocation multiple alignment size
-#[cfg(target_arch = "riscv")]
+#[cfg(target_arch = "riscv64")]

Review comment:
       @vertexclique  I wonder if you have any thoughts?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb commented on pull request #769: Add support for riscv64

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-921271536


   Thanks @felixonmars !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb commented on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-921229364


   @felixonmars  what command are you using to compile against `riscv64`? 
   
   When I tried to run 
   ```
   cargo build --target riscv64
   cargo build --target riscv64
   error: failed to run `rustc` to learn about target-specific information
   ```
   
   I am sorry for my ignorance here -- I don't have access to a machine with such an architecture and haven't tried cross compiling myself. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb commented on pull request #769: Fix riscv64 target_arch

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #769:
URL: https://github.com/apache/arrow-rs/pull/769#issuecomment-920243142


   So I also didn't see `riscv64` as a supported architecture. The supported architectures from my `rustc` (1.55) are:
   
   ```shell
   alamb@MacBook-Pro arrow-rs % cargo build --target riscv64
   cargo build --target riscv64
   error: failed to run `rustc` to learn about target-specific information
   
   Caused by:
     process didn't exit successfully: `/Users/alamb/.cargo/bin/sccache rustc - --crate-name ___ --print=file-names -C debuginfo=1 --target riscv64 --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
     --- stderr
     error: Error loading target specification: Could not find specification for target "riscv64". Run `rustc --print target-list` for a list of built-in targets
   
   alamb@MacBook-Pro arrow-rs % rustc --print target-list | grep risc
   rustc --print target-list | grep risc
   riscv32gc-unknown-linux-gnu
   riscv32gc-unknown-linux-musl
   riscv32i-unknown-none-elf
   riscv32imac-unknown-none-elf
   riscv32imc-unknown-none-elf
   riscv64gc-unknown-linux-gnu
   riscv64gc-unknown-linux-musl
   riscv64gc-unknown-none-elf
   riscv64imac-unknown-none-elf
   ``


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org