You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@iotdb.apache.org by "Bo Zhang (Jira)" <ji...@apache.org> on 2022/02/28 15:03:00 UTC
[jira] [Commented] (IOTDB-2628) new_sync branch,fix some bugs to avoid resource leak.
[ https://issues.apache.org/jira/browse/IOTDB-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498954#comment-17498954 ]
Bo Zhang commented on IOTDB-2628:
---------------------------------
https://github.com/apache/iotdb/pull/5137
> new_sync branch,fix some bugs to avoid resource leak.
> -----------------------------------------------------
>
> Key: IOTDB-2628
> URL: https://issues.apache.org/jira/browse/IOTDB-2628
> Project: Apache IoTDB
> Issue Type: Bug
> Reporter: Bo Zhang
> Assignee: Bo Zhang
> Priority: Major
>
> 1) org.apache.iotdb.db.newsync.sender.recovery.TsFilePipeLogAnalyzer#parseFile
> inputStream.close(); can cause NPE.
> Need use try-with-resource to handle .
>
> 2) org.apache.iotdb.db.newsync.pipedata.DeletionPipeData#sendToTransport
> a) may cause not close stream
> b) should remove : System.out.println()
>
> 3) org.apache.iotdb.db.engine.storagegroup.VirtualStorageGroupProcessor#registerSyncDataCollector
> Here, it's better to use "try - finally" to release lock.
>
> 4) org.apache.iotdb.db.engine.storagegroup.VirtualStorageGroupProcessor#collectDataForSync
> similiar to above one case.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)