[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

[zhuoliu <gi...@git.apache.org>]

Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/743#discussion_r43939104
  
    --- Diff: external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java ---
    @@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception {
     
         private  static Config getConfig(String brokerConnectionString) {
             Config conf = new Config();
    -        Map config = new HashMap();
             Properties props = new Properties();
    -        props.put("metadata.broker.list", brokerConnectionString);
    -        props.put("request.required.acks", "1");
    -        props.put("serializer.class", "kafka.serializer.StringEncoder");
    +        props.put("bootstrap.servers", brokerConnectionString);
    +        props.put("acks", "1");
    +        props.put("key.serializer", "org.apache.kafka.common.serialization.StringSerializer");
    --- End diff --
    
    Agreed, since it is a test, making it not configurable should be OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---