[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

["kwin (via GitHub)" <gi...@apache.org>]

kwin commented on code in PR #165:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1174593372


##########
src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java:
##########
@@ -117,6 +117,19 @@ public class ContentPackage2FeatureModelConverter extends BaseVaultPackageScanne
 
     private IndexManager indexManager = new DefaultIndexManager();
 
+    private RunmodePolicy runmodePolicy = RunmodePolicy.DIRECT_ONLY;
+
+    public enum RunmodePolicy {

Review Comment:
   ```suggestion
       public enum RunModePolicy {
   ```
   
   Also in several other places the camel casing should be fixed. It is run mode not runmode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org