[jira] [Comment Edited] (CASSANDRA-11922) BatchlogManagerTest is failing intermittently

["Alex Petrov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306603#comment-15306603 ] 

Alex Petrov edited comment on CASSANDRA-11922 at 5/30/16 12:44 PM:
-------------------------------------------------------------------

It seems that there's a race condition between the write to {{pause}} which sets {{isActive}} to {{false}} and the check for {{isEnabled}} which reads this flag, which results into compactions activated despite the fact they shouldn't.

I've ran the test with additional write lock 10 times and all 10 times it passed. Without the same lock, it was failing almost all the time on my machine. Added a multiplexed test to run {{BatchlogManagerTest}} 50 times, too:

|[trunk|https://github.com/ifesdjeen/cassandra/tree/11922-trunk]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11922-trunk-testall/]|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11922-trunk-dtest/]|[multiplexed|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11922-trunk-multiplexed/]|


was (Author: ifesdjeen):
|[trunk|https://github.com/ifesdjeen/cassandra/tree/11922-trunk] |[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11922-trunk-testall/] |[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11922-trunk-dtest/] |

> BatchlogManagerTest is failing intermittently
> ---------------------------------------------
>
>                 Key: CASSANDRA-11922
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11922
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>
> {{BatchlogManagerTest}} is failing sometimes with the following trace:
> {code}
>     [junit] Testcase: testLegacyReplay(org.apache.cassandra.batchlog.BatchlogManagerTest):      FAILED
>     [junit] [BigTableReader(path='/Users/oleksandrpetrov/foss/java/cassandra/build/test/cassandra/data:0/system/batches-919a4bc57a333573b03e13fc3f68b465/mb-2-big-Data.db'), BigTableReader(path='/Users/oleksandrpetrov/foss/java/cassandra/build/test/cassandra/data:0/system/batches-919a4bc57a333573b03e13fc3f68b465/mb-1-big-Data.db')]
>     [junit] junit.framework.AssertionFailedError: [BigTableReader(path='/Users/oleksandrpetrov/foss/java/cassandra/build/test/cassandra/data:0/system/batches-919a4bc57a333573b03e13fc3f68b465/mb-2-big-Data.db'), BigTableReader(path='/Users/oleksandrpetrov/foss/java/cassandra/build/test/cassandra/data:0/system/batches-919a4bc57a333573b03e13fc3f68b465/mb-1-big-Data.db')]
>     [junit]     at org.apache.cassandra.db.ColumnFamilyStore.discardSSTables(ColumnFamilyStore.java:2521)
>     [junit]     at org.apache.cassandra.db.ColumnFamilyStore$6.run(ColumnFamilyStore.java:2155)
>     [junit]     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>     [junit]     at org.apache.cassandra.db.ColumnFamilyStore.runWithCompactionsDisabled(ColumnFamilyStore.java:2224)
>     [junit]     at org.apache.cassandra.db.ColumnFamilyStore.truncateBlocking(ColumnFamilyStore.java:2166)
>     [junit]     at org.apache.cassandra.batchlog.BatchlogManagerTest.setUp(BatchlogManagerTest.java:100)
> {code}
> Sometimes there are running compactions despite the fact they should have been waited upon before truncate. {{pause}} and {{resume}} are called on the {{CompactionStrategyManager}} appropriately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)