You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "GWphua (via GitHub)" <gi...@apache.org> on 2025/02/27 03:22:54 UTC
[PR] Update deprecated com.google.common.io.Files#write (druid)
GWphua opened a new pull request, #17761:
URL: https://github.com/apache/druid/pull/17761
### Description
Initiated by @kfaraz https://github.com/apache/druid/pull/17742#discussion_r1964777359
#### Replace all deprecated write uses
#### Added a forbidden-apis entry for com.google.common.io.Files#write
<hr>
##### Key changed/added classes in this PR
* `druid-forbidden-apis`
* Test files using the deprecated write API.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update deprecated com.google.common.io.Files#write (druid)
Posted by "GWphua (via GitHub)" <gi...@apache.org>.
GWphua commented on PR #17761:
URL: https://github.com/apache/druid/pull/17761#issuecomment-2689820479
@kfaraz thanks for the update. I have resolved the merge conflicts, and the previously failing unit test has succeeded. Would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update deprecated com.google.common.io.Files#write (druid)
Posted by "GWphua (via GitHub)" <gi...@apache.org>.
GWphua commented on PR #17761:
URL: https://github.com/apache/druid/pull/17761#issuecomment-2686810275
Unit test failure seems irrelevant to PR. Test unrelated to changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update deprecated com.google.common.io.Files#write (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #17761:
URL: https://github.com/apache/druid/pull/17761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update deprecated com.google.common.io.Files#write (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #17761:
URL: https://github.com/apache/druid/pull/17761#issuecomment-2689658485
@GWphua , there are some merge conflicts now. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org