You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/12/05 18:17:21 UTC

[GitHub] [cassandra] subkanthi commented on a change in pull request #1354: [16436] - Added startup check for read_ahead_kb setting.

subkanthi commented on a change in pull request #1354:
URL: https://github.com/apache/cassandra/pull/1354#discussion_r762597216



##########
File path: test/unit/org/apache/cassandra/service/StartupChecksTest.java
##########
@@ -103,6 +103,13 @@ public void compatibilityCheckIgnoresNonDbFiles() throws Exception
         startupChecks.verify();
     }
 
+    @Test
+    public void checkReadAheadKbSettingCheck() throws Exception
+    {
+        startupChecks = startupChecks.withTest(StartupChecks.checkReadAheadKbSetting);
+        startupChecks.verify();

Review comment:
       Not sure if there should be some sort of assert, because this doesnt test much.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org