You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/07 05:06:18 UTC
[GitHub] [incubator-doris] wangshuo128 opened a new pull request, #8297: [build](fe) Support building an individual maven module.
wangshuo128 opened a new pull request, #8297:
URL: https://github.com/apache/incubator-doris/pull/8297
# Proposed changes
Current, if we build an individual FE maven module, e.g., build `fe-core` moudle via `mvn clean package -pl fe-core`, the below error would occur
```
[ERROR] Failed to execute goal on project fe-core: Could not resolve dependencies for project org.apache.doris:fe-core:jar:0.15-SNAPSHOT: Failed to collect dependencies at org.apache.doris:spark-dpp:jar:0.15-SNAPSHOT: Failed to read artifact descriptor for org.apache.doris:spark-dpp:jar:0.15-SNAPSHOT: Could not find artifact org.apache.doris:fe:pom:${revision}
```
It's because the maven module version is a property defined in the root pom.xml:
https://github.com/apache/incubator-doris/blob/246ac4e37aa4da6836b7850cb990f02d1c3725a3/fe/pom.xml#L121
This PR tried to fix this issue.
1. Use the version value in every pom.xml file instead of a property in the root pom.xml
2. If we want to change the project version, we could run the following commands in the `fe` dir:
``` bash
mvn versions:set -DnewVersion=${new_version}
mvn versions:commit
```
Please see https://www.mojohaus.org/versions-maven-plugin/examples/set.html for more details.
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: no
4. Has unit tests been added: no
5. Has document been added or modified: no
6. Does it need to update dependencies: no
7. Are there any changes that cannot be rolled back: no
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #8297: [build](fe) Support building an individual maven module.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8297: [build](fe) Support building an individual maven module.
URL: https://github.com/apache/doris/pull/8297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #8297: [build](fe) Support building an individual maven module.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8297:
URL: https://github.com/apache/doris/pull/8297#issuecomment-1396262501
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangshuo128 commented on pull request #8297: [build](fe) Support building an individual maven module.
Posted by GitBox <gi...@apache.org>.
wangshuo128 commented on PR #8297:
URL: https://github.com/apache/incubator-doris/pull/8297#issuecomment-1120136338
> you can use `mvn -Drevision=0.15-SNAPSHOT` to compile child module
It seems that using `-Drevision` does not work. So I reopen this PR. Looking forward to more thoughts about this.
cc @yangzhg @EmmyMiao87 @morrySnow @924060929 @morningman :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org