You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/20 10:01:57 UTC

[GitHub] [tvm] leandron opened a new pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

leandron opened a new pull request #8089:
URL: https://github.com/apache/tvm/pull/8089


   Updates ci_lint image to use UTF-8 encoding.
   
    * Sets environment shell encoding to UTF-8
   
    * This prevents the black formatting tool to exit with the following error:
      "RuntimeError: Click will abort further execution because Python was
       configured to use ASCII as encoding for the environment"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8089:
URL: https://github.com/apache/tvm/pull/8089#issuecomment-845500964


   @leandron if it's ok, i'd like to hold this change until we finish #7995. i think it's likely not going to affect it, but we have a few CUDA changes to make in order to make any progress on updating the images and i'd like to not mix future changes. that said, if it's pressing, i don't think this one will affect much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8089:
URL: https://github.com/apache/tvm/pull/8089#issuecomment-845525468


   @tkonolige wdyt? i'm holding most changes, but this one a) only affects ci-lint and b) is pretty low-impact


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8089:
URL: https://github.com/apache/tvm/pull/8089#issuecomment-845515921


   > @leandron if it's ok, i'd like to hold this change until we finish #7995. i think it's likely not going to affect it, but we have a few CUDA changes to make in order to make any progress on updating the images and i'd like to not mix future changes. that said, if it's pressing, i don't think this one will affect much.
   
   It would be good to merge as it is very low impact - if possible, so that I can keep validating the images overnight.
   
   In case you want to keep this to organise #7995 - I also support it -, I’ll manage with some local change on my CI jobs. Let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tkonolige commented on pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #8089:
URL: https://github.com/apache/tvm/pull/8089#issuecomment-845550374


   This should be an easy rebuild. Let's merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8089:
URL: https://github.com/apache/tvm/pull/8089


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8089:
URL: https://github.com/apache/tvm/pull/8089#issuecomment-845107591


   That's just a problem not seen yet, before we implement our image rebuilds.
   
   cc @tqchen @areusch for reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #8089: [CI][Docker] set environment variables for UTF-8, to prevent errors when running `black`

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8089:
URL: https://github.com/apache/tvm/pull/8089#issuecomment-845492727


   @areusch if you have a minute, can you review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org