You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Neil Griffin (JIRA)" <ji...@apache.org> on 2018/03/06 23:28:00 UTC

[jira] [Updated] (PLUTO-696) TCK: Contesting V2 tests that expect PortletURL.setParameter methods to remove the value when null is passed

     [ https://issues.apache.org/jira/browse/PLUTO-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neil Griffin updated PLUTO-696:
-------------------------------
    Description: 
Apache Pluto fails the legacy Portlet 2.0 TCK SetParameterWithValuesIllegalArgumentExceptionTestPortlet because {{PortletURL.setParameter(String name, String value)}} and {{PortletURL.setParameter(String name, String... values)}} do not throw {{IllegalArgumentException}} when {{null}} is passed for the value.

The following V 2.0 tests in the new Portlet 3.0 TCK are testing the Portlet 3.0 behavior, which is to *remove* the parameter from the URL when {{null}} is passed:
- V2URLTests_BaseURL_ApiRenderActurl_setParameterB7
- V2URLTests_BaseURL_ApiRenderRenurl_setParameterB7
- V2URLTests_BaseURL_ApiRenderResurl_setParameterB7

In order to fix this problem, these tests should test for {{IllegalArgumentException}}, and testing for removal should be done in V3URLTests.

  was:Apache Pluto fails the legacy Portlet 2.0 TCK SetParameterWithValuesIllegalArgumentExceptionTestPortlet because {{PortletURL.setParameter(String name, String value)}} and {{PortletURL.setParameter(String name, String... values)}} do not throw {{IllegalArgumentException}} when null is passed for the value.


> TCK: Contesting V2 tests that expect PortletURL.setParameter methods to remove the value when null is passed
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-696
>                 URL: https://issues.apache.org/jira/browse/PLUTO-696
>             Project: Pluto
>          Issue Type: Bug
>          Components: tck
>    Affects Versions: 3.0.0
>            Reporter: Neil Griffin
>            Assignee: Neil Griffin
>            Priority: Major
>             Fix For: 3.0.1
>
>
> Apache Pluto fails the legacy Portlet 2.0 TCK SetParameterWithValuesIllegalArgumentExceptionTestPortlet because {{PortletURL.setParameter(String name, String value)}} and {{PortletURL.setParameter(String name, String... values)}} do not throw {{IllegalArgumentException}} when {{null}} is passed for the value.
> The following V 2.0 tests in the new Portlet 3.0 TCK are testing the Portlet 3.0 behavior, which is to *remove* the parameter from the URL when {{null}} is passed:
> - V2URLTests_BaseURL_ApiRenderActurl_setParameterB7
> - V2URLTests_BaseURL_ApiRenderRenurl_setParameterB7
> - V2URLTests_BaseURL_ApiRenderResurl_setParameterB7
> In order to fix this problem, these tests should test for {{IllegalArgumentException}}, and testing for removal should be done in V3URLTests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)