You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 10:52:30 UTC
[GitHub] [spark] LSturtew opened a new pull request #32108: [SPARK-34983][PYTHON]Renaming the package alias from pp to ps
LSturtew opened a new pull request #32108:
URL: https://github.com/apache/spark/pull/32108
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
renamed `pyspark.pandas` alias to `ps`
### Why are the changes needed?
the `pyspark.pandas` alias in this part of the codebase was `pp`
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32108:
URL: https://github.com/apache/spark/pull/32108#discussion_r610999262
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -10859,7 +10859,7 @@ def query(self, expr, inplace=False) -> Optional["DataFrame"]:
So, for example, to use `@` syntax, make sure the variable is serialized by, for
example, putting it within the closure as below.
- >>> df = pp.DataFrame({'A': range(2000), 'B': range(2000)})
+ >>> df = ps.DataFrame({'A': range(2000), 'B': range(2000)})
>>> def query_func(pdf):
... num = 1995
... return pdf.query('A > @num')
Review comment:
Let's also fix backticpp -> backticks https://github.com/apache/spark/pull/32103/files#diff-f8fd3a7153d9fce3d286400b80a4e61b3f9770e42177082f6c0adc507ddd2999L10879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32108: [SPARK-34983][PYTHON]Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32108:
URL: https://github.com/apache/spark/pull/32108#discussion_r610998644
##########
File path: python/pyspark/pandas/base.py
##########
@@ -42,7 +42,7 @@
TimestampType,
)
-from pyspark import pandas as pp # For running doctests and reference resolution in PyCharm.
+from pyspark import pandas as ps # For running doctests and reference resolution in PyCharm.
Review comment:
I am actually working on it in https://github.com/apache/spark/pull/32103 ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32108:
URL: https://github.com/apache/spark/pull/32108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817081758
I am fine with dropping mine considering that it's first contribution from @LSturtew. Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32108:
URL: https://github.com/apache/spark/pull/32108#discussion_r610999052
##########
File path: python/pyspark/pandas/accessors.py
##########
@@ -269,20 +269,20 @@ def apply_batch(self, func, args=(), **kwds) -> "DataFrame":
Review comment:
https://github.com/apache/spark/pull/32103/files#diff-eca10d3f01d801e744b5217cb7b571a30ec003e68d1af624086632a90fcc97e2R477 this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817101156
**[Test build #137167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137167/testReport)** for PR 32108 at commit [`4a179b6`](https://github.com/apache/spark/commit/4a179b69a0cb2fbd3bfca0d22818dad01e98a8b6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817081954
**[Test build #137163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137163/testReport)** for PR 32108 at commit [`e1719a5`](https://github.com/apache/spark/commit/e1719a50ec4bb2e522f2f9a3f0ca513d10fd3d0a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817086945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32108:
URL: https://github.com/apache/spark/pull/32108#discussion_r610999089
##########
File path: python/pyspark/pandas/typedef/string_typehints.py
##########
@@ -23,12 +23,12 @@
def resolve_string_type_hint(tpe):
- import pyspark.pandas as pp
+ import pyspark.pandas as ps
from pyspark.pandas import DataFrame, Series
locs = {
- "pp": pp,
- "koalas": pp,
+ "ps": ps,
+ "koalas": ps,
Review comment:
Let's fix this to "pyspark.pandas" too while we're here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817105649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817081700
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32108:
URL: https://github.com/apache/spark/pull/32108#discussion_r610999039
##########
File path: python/pyspark/pandas/accessors.py
##########
@@ -269,20 +269,20 @@ def apply_batch(self, func, args=(), **kwds) -> "DataFrame":
Review comment:
Would you mind fixing chunpp -> chunks too since we're here? see https://github.com/apache/spark/pull/32103/files#diff-eca10d3f01d801e744b5217cb7b571a30ec003e68d1af624086632a90fcc97e2R268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817103957
**[Test build #137167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137167/testReport)** for PR 32108 at commit [`4a179b6`](https://github.com/apache/spark/commit/4a179b69a0cb2fbd3bfca0d22818dad01e98a8b6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817100721
**[Test build #137166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137166/testReport)** for PR 32108 at commit [`5fbd795`](https://github.com/apache/spark/commit/5fbd79536ed8745b29f13c1b3c2d54fd76afe6b4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LSturtew commented on pull request #32108: [SPARK-34983][PYTHON]Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
LSturtew commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-816609518
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817086944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817086002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817100721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32108: [SPARK-34983][PYTHON]Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32108:
URL: https://github.com/apache/spark/pull/32108#discussion_r610734439
##########
File path: python/pyspark/pandas/base.py
##########
@@ -42,7 +42,7 @@
TimestampType,
)
-from pyspark import pandas as pp # For running doctests and reference resolution in PyCharm.
+from pyspark import pandas as ps # For running doctests and reference resolution in PyCharm.
Review comment:
Is this the proposal of this PR?
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817081954
**[Test build #137163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137163/testReport)** for PR 32108 at commit [`e1719a5`](https://github.com/apache/spark/commit/e1719a50ec4bb2e522f2f9a3f0ca513d10fd3d0a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817106455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817103607
**[Test build #137166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137166/testReport)** for PR 32108 at commit [`5fbd795`](https://github.com/apache/spark/commit/5fbd79536ed8745b29f13c1b3c2d54fd76afe6b4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817084715
**[Test build #137163 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137163/testReport)** for PR 32108 at commit [`e1719a5`](https://github.com/apache/spark/commit/e1719a50ec4bb2e522f2f9a3f0ca513d10fd3d0a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817433529
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32108: [SPARK-34983][PYTHON] Renaming the package alias from pp to ps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32108:
URL: https://github.com/apache/spark/pull/32108#issuecomment-817106455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org