You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/25 20:21:28 UTC
[GitHub] [maven-pmd-plugin] pzygielo opened a new pull request #26: Revert upgrade to 6.26
pzygielo opened a new pull request #26:
URL: https://github.com/apache/maven-pmd-plugin/pull/26
I propose to revert recent upgrade to 6.26.
I suggest new IT, to test configured PMD against project with some provided dependency.
Build of proposed commits:
:heavy_check_mark: First commit - new IT based on previous version with PMD 6.23
:red_circle: Merge update of PMD to 6.26
:heavy_check_mark: Revert PMD update
@adangel please take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] pzygielo closed pull request #26: Revert upgrade to 6.26
Posted by GitBox <gi...@apache.org>.
pzygielo closed pull request #26:
URL: https://github.com/apache/maven-pmd-plugin/pull/26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] pzygielo commented on pull request #26: Revert upgrade to 6.26
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #26:
URL: https://github.com/apache/maven-pmd-plugin/pull/26#issuecomment-663902570
If accepted - I can rebase and reopen #25, as 6.25.0 works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] pzygielo commented on pull request #26: Revert upgrade to 6.26
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #26:
URL: https://github.com/apache/maven-pmd-plugin/pull/26#issuecomment-663963914
Closing - as revert - should it be decided to do so - can be performed directly on GH without additional commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel commented on pull request #26: Revert upgrade to 6.26
Posted by GitBox <gi...@apache.org>.
adangel commented on pull request #26:
URL: https://github.com/apache/maven-pmd-plugin/pull/26#issuecomment-663960783
If we were to release m-pmd-p, I'd agree, that this is a blocker and needs to be reverted.
I'm not sure, if adding a IT in m-pmd-p for a bug in PMD makes sense. The test case is very, very specific and would only trigger on this special case (UnusedImport)...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] pzygielo commented on pull request #26: Revert upgrade to 6.26
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #26:
URL: https://github.com/apache/maven-pmd-plugin/pull/26#issuecomment-663963733
@adangel thanks for checking
> I'm not sure, if adding a IT in m-pmd-p for a bug in PMD makes sense.
Now I see it. You're right - such IT doesn't fit here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org