[GitHub] [pulsar] yuruguo commented on a change in pull request #13192: [Broker] Add removeMaxConsumersPerSubscription method for v1 namespace

[GitBox <gi...@apache.org>]

yuruguo commented on a change in pull request #13192:
URL: https://github.com/apache/pulsar/pull/13192#discussion_r764666813



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
##########
@@ -1094,7 +1094,7 @@ public void setMaxConsumersPerTopic(@PathParam("property") String property, @Pat
     @ApiOperation(value = "Get maxConsumersPerSubscription config on a namespace.")
     @ApiResponses(value = {@ApiResponse(code = 403, message = "Don't have admin permission"),
             @ApiResponse(code = 404, message = "Namespace does not exist")})
-    public int getMaxConsumersPerSubscription(@PathParam("property") String property,
+    public Integer getMaxConsumersPerSubscription(@PathParam("property") String property,

Review comment:
       **Note**: 
   The `maxConsumersPerSubscription` will become `null` When the `removeMaxConsumersPerSubscription` method is executed, and then `NPE` will appear when get maxConsumersPerSubscription, so we need to change `int` to `Integer`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org