[GitHub] [airflow] ianstanton commented on a change in pull request #14152: Helm RBAC Best Practices

[GitBox <gi...@apache.org>]

ianstanton commented on a change in pull request #14152:
URL: https://github.com/apache/airflow/pull/14152#discussion_r619368715



##########
File path: chart/templates/cleanup/cleanup-serviceaccount.yaml
##########
@@ -18,11 +18,11 @@
 ################################
 ## Airflow Cleanup ServiceAccount
 #################################
-{{- if and .Values.rbacEnabled .Values.cleanup.enabled }}
+{{- if and .Values.cleanup.serviceAccount.create .Values.cleanup.enabled }}
 kind: ServiceAccount
 apiVersion: v1
 metadata:
-  name: {{ .Release.Name }}-cleanup
+  name: {{ include "cleanup.serviceAccountName" . }}
   labels:

Review comment:
       Is there a reason we don't have the option to add annotations in this service account?

##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -480,9 +534,6 @@ The following tables lists the configurable parameters of the Airflow chart and
    * - ``multiNamespaceMode``
      - Whether the KubernetesExecutor can launch pods in multiple namespaces
      - ``1``
-   * - ``serviceAccountAnnottions.*``
-     - Map of annotations for worker, webserver, scheduler kubernetes service accounts
-     - ``{}``
 

Review comment:
       @DerekHeldtWerle It looks like we need related documentation for `jobs`, `redis` and `cleanup` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org