You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Billy Liu (JIRA)" <ji...@apache.org> on 2018/01/24 11:12:00 UTC

[jira] [Resolved] (KYLIN-2801) Make default precision and scale in DataType (for hive) configurable

     [ https://issues.apache.org/jira/browse/KYLIN-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Billy Liu resolved KYLIN-2801.
------------------------------
       Resolution: Fixed
         Assignee: hongbin ma
    Fix Version/s: v2.3.0

Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/a3d42f11

> Make default precision and scale in DataType (for hive) configurable
> --------------------------------------------------------------------
>
>                 Key: KYLIN-2801
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2801
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: hongbin ma
>            Assignee: hongbin ma
>            Priority: Major
>             Fix For: v2.3.0
>
>
> currently these values are hard coded:
> {code:java}
>   // FIXME 256 for unknown string precision
>         if ((name.equals("char") || name.equals("varchar")) && precision == -1) {
>             precision = 256; // to save memory at frontend, e.g. tableau will
>                              // allocate memory according to this
>             if (name.equals("char")) {
>                 precision -= 1; //at most 255 according to https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-CharcharChar
>             }
>         }
>         // FIXME (19,4) for unknown decimal precision
>         if ((name.equals("decimal") || name.equals("numeric")) && precision == -1) {
>             precision = 19;
>             scale = 4;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)