You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/03 11:12:21 UTC
[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4931
Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
......................................................................
KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
Currently row presence in RowSets is binary: either the row is alive,
in which case CheckRowPresent() sets the out bool param to true, or
it's not present or deleted, in which case the out param is set to
false.
With REINSERTs in delta files this is not enough. In particular we
need to distinguish the case where the row is present but deleted
so that we can apply a REINSERT mutation.
Change-Id: Ia78ad184f1415db96fe99c8577e5f52326dec912
---
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mock-rowsets.h
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet.cc
11 files changed, 104 insertions(+), 90 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/4931/1
--
To view, visit http://gerrit.cloudera.org:8080/4931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia78ad184f1415db96fe99c8577e5f52326dec912
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has abandoned this change.
Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia78ad184f1415db96fe99c8577e5f52326dec912
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()
......................................................................
Patch Set 1:
One question related to this: if we already have existing data where a row is inserted and deleted in several rowsets, don't we already need to handle the "ghost row" case in compaction for the purpose of upgrades?
--
To view, visit http://gerrit.cloudera.org:8080/4931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78ad184f1415db96fe99c8577e5f52326dec912
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No