You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/05/15 11:42:15 UTC
[GitHub] andrzej-kaczmarek commented on a change in pull request #98: Update
Mesh to use NPL
andrzej-kaczmarek commented on a change in pull request #98: Update Mesh to use NPL
URL: https://github.com/apache/mynewt-nimble/pull/98#discussion_r188254445
##########
File path: nimble/include/nimble/nimble_npl.h
##########
@@ -68,8 +68,13 @@ struct ble_npl_eventq *ble_npl_eventq_dflt_get(void);
void ble_npl_eventq_init(struct ble_npl_eventq *evq);
+struct ble_npl_event *ble_npl_eventq_get_tmo(struct ble_npl_eventq *evq,
+ ble_npl_time_t tmo);
+
struct ble_npl_event *ble_npl_eventq_get(struct ble_npl_eventq *evq);
+struct ble_npl_event *ble_npl_eventq_get_no_wait(struct ble_npl_eventq *evq);
Review comment:
this can be actually `ble_npl_eventq_get_tmo(evq, 0)` - no need to create too many functions
(but I'd keep `ble_npl_evqnt_get` for "historical" reasons ;-) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services