You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/08/27 06:36:50 UTC

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #37: Search for programs needed for tests

ams-tschoening commented on a change in pull request #37:
URL: https://github.com/apache/logging-log4cxx/pull/37#discussion_r478184458



##########
File path: CMakeLists.txt
##########
@@ -123,3 +123,10 @@ message(STATUS "  logchar type .................... : ${LOG4CXX_CHAR}")
 message(STATUS "  Using libESMTP .................. : ${HAS_LIBESMTP}")
 message(STATUS "  ODBC library .................... : ${HAS_ODBC}")
 message(STATUS "  syslog .......................... : ${HAS_SYSLOG}")
+
+if(BUILD_TESTING)
+message(STATUS "Applications required for tests:")
+message(STATUS "  zip ............................. : ${ZIP_EXE}")

Review comment:
       The first thing I wondered when reading "*_EXE" was about Windows vs. non-Windows. How about changing the name to "*_BIN" or "*_APP" instead to make clear it's OS-independent?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org