You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@syncope.apache.org by ilgrosso <gi...@git.apache.org> on 2017/08/25 06:20:36 UTC

[GitHub] syncope issue #61: SYNCOPE-917 Add tutorial/use-case "Configure a database r...

Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/61
  
    Hi @clucgdc thanks for this PR.
    You need to rename all files with JPG (uppercase) extension to jpg (lowercase), otherwise when building on non-Windows boxes you'll get the following errors:
    
    ```
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource04.jpg
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource05.jpg
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource06.jpg
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource07.jpg
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource08.jpg
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource09.jpg
    asciidoctor: WARNING: image to embed not found or not readable: /home/ilgrosso/work/syncope/syncope2/src/main/asciidoc/images/configdatabaseresource10.jpg
    ```
    
    Please note that for the fix above and other observation during review, you should not close this PR and open a new one (as you did with #60): just keep committing and pushing on your own fork, and new commits will be added here.
    Once the review will be successfully completed, I'll ask you to squash the commits to keep our history clear.
    
    Thank you again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---