You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/02/08 02:59:36 UTC
svn commit: r907537 - /tomcat/trunk/test/org/apache/TestAll.java
Author: markt
Date: Mon Feb 8 01:59:35 2010
New Revision: 907537
URL: http://svn.apache.org/viewvc?rev=907537&view=rev
Log:
Update with recently added tests
Modified:
tomcat/trunk/test/org/apache/TestAll.java
Modified: tomcat/trunk/test/org/apache/TestAll.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/TestAll.java?rev=907537&r1=907536&r2=907537&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/TestAll.java (original)
+++ tomcat/trunk/test/org/apache/TestAll.java Mon Feb 8 01:59:35 2010
@@ -23,17 +23,32 @@
import org.apache.catalina.connector.TestKeepAliveCount;
import org.apache.catalina.connector.TestRequest;
import org.apache.catalina.core.TestStandardContext;
+import org.apache.catalina.deploy.TestSecurityConstraint;
+import org.apache.catalina.deploy.TestWebXml;
import org.apache.catalina.deploy.TestWebXmlOrdering;
import org.apache.catalina.ha.session.TestSerializablePrincipal;
import org.apache.catalina.startup.TestTomcat;
import org.apache.catalina.startup.TestTomcatSSL;
+import org.apache.catalina.util.TestRequestUtil;
+import org.apache.catalina.valves.TestRemoteIpValve;
import org.apache.el.TestELEvaluation;
import org.apache.el.TestELInJsp;
+import org.apache.el.TestMethodExpressionImpl;
+import org.apache.el.TestValueExpressionImpl;
import org.apache.el.lang.TestELSupport;
import org.apache.jasper.compiler.TestAttributeParser;
import org.apache.jasper.compiler.TestGenerator;
+import org.apache.jasper.compiler.TestParser;
+import org.apache.jasper.compiler.TestScriptingVariabler;
import org.apache.jasper.compiler.TestValidator;
import org.apache.tomcat.util.http.TestCookies;
+import org.apache.tomcat.util.http.TestCookiesAllowEquals;
+import org.apache.tomcat.util.http.TestCookiesAllowHttpSeps;
+import org.apache.tomcat.util.http.TestCookiesDefaultSysProps;
+import org.apache.tomcat.util.http.TestCookiesDisallowEquals;
+import org.apache.tomcat.util.http.TestCookiesNoFwdStrictSysProps;
+import org.apache.tomcat.util.http.TestCookiesNoStrictNamingSysProps;
+import org.apache.tomcat.util.http.TestCookiesStrictSysProps;
import org.apache.tomcat.util.res.TestStringManager;
public class TestAll {
@@ -46,28 +61,46 @@
suite.addTestSuite(TestRequest.class);
// core
suite.addTestSuite(TestStandardContext.class);
+ // deploy
+ suite.addTestSuite(TestSecurityConstraint.class);
+ suite.addTestSuite(TestWebXml.class);
+ suite.addTestSuite(TestWebXmlOrdering.class);
// ha.session
suite.addTestSuite(TestSerializablePrincipal.class);
// startup
suite.addTestSuite(TestTomcat.class);
suite.addTestSuite(TestTomcatSSL.class);
- suite.addTestSuite(TestWebXmlOrdering.class);
// tribes
// suite.addTest(TribesTestSuite.suite());
+ // util
+ suite.addTestSuite(TestRequestUtil.class);
+ // valves
+ suite.addTestSuite(TestRemoteIpValve.class);
// o.a.el
suite.addTestSuite(TestELSupport.class);
suite.addTestSuite(TestELEvaluation.class);
suite.addTestSuite(TestELInJsp.class);
+ suite.addTestSuite(TestMethodExpressionImpl.class);
+ suite.addTestSuite(TestValueExpressionImpl.class);
// o.a.jasper
suite.addTestSuite(TestAttributeParser.class);
suite.addTestSuite(TestGenerator.class);
+ suite.addTestSuite(TestParser.class);
+ suite.addTestSuite(TestScriptingVariabler.class);
suite.addTestSuite(TestValidator.class);
// o.a.tomcat.util
// http
suite.addTestSuite(TestCookies.class);
+ suite.addTestSuite(TestCookiesAllowEquals.class);
+ suite.addTestSuite(TestCookiesAllowHttpSeps.class);
+ suite.addTestSuite(TestCookiesDefaultSysProps.class);
+ suite.addTestSuite(TestCookiesDisallowEquals.class);
+ suite.addTestSuite(TestCookiesNoFwdStrictSysProps.class);
+ suite.addTestSuite(TestCookiesNoStrictNamingSysProps.class);
+ suite.addTestSuite(TestCookiesStrictSysProps.class);
// res
suite.addTestSuite(TestStringManager.class);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r907537 - /tomcat/trunk/test/org/apache/TestAll.java
Posted by sebb <se...@gmail.com>.
On 08/02/2010, markt@apache.org <ma...@apache.org> wrote:
> Author: markt
> Date: Mon Feb 8 01:59:35 2010
> New Revision: 907537
>
> URL: http://svn.apache.org/viewvc?rev=907537&view=rev
> Log:
> Update with recently added tests
>
> Modified:
> tomcat/trunk/test/org/apache/TestAll.java
>
Is it really necessary to keep this file at all?
It's not used by the Ant test target, and it's a pain keeping it up to date.
Likewise for any other suite() methods - unless there is a sequencing
requirement, there's no point in using them.
Nor is there any need for main() methods in test classes.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org