You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/01 02:45:42 UTC
[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #4455: makefile: let `clean_context` in `distclean` command
zhuyanlinzyl opened a new pull request #4455:
URL: https://github.com/apache/incubator-nuttx/pull/4455
In multi-jobs build, `distclean` may be faster than `clean_context`,
Fix the case `distclean` use the dirctorys that have been
removed by `clean_context`
Change-Id: I99f5c6e401289493f51b909bafd4c465e097175b
## Summary
## Impact
No
## Testing
make clean/distclean pass on sim/arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #4455: makefile: let `clean_context` in `distclean` command
Posted by GitBox <gi...@apache.org>.
zhuyanlinzyl commented on pull request #4455:
URL: https://github.com/apache/incubator-nuttx/pull/4455#issuecomment-910206790
When run `make disclean -j64` in board/xtensa with toolchain xt-xcc
Their have the case
1 clean_context run the command:
`$(Q) $(DIRUNLINK) $(ARCH_SRC)/board`
2 distclean run the command:
`make -C board distclean`
but `board` has be unlink by clean_context early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4455: makefile: let `clean_context` in `distclean` command
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4455:
URL: https://github.com/apache/incubator-nuttx/pull/4455#issuecomment-910118643
What was the observed issue? Since `clean_context` is a prerequisite it should be executed before `distclean` recipe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4455: makefile: let `clean_context` in `distclean` command
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4455:
URL: https://github.com/apache/incubator-nuttx/pull/4455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4455: makefile: let `clean_context` in `distclean` command
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4455:
URL: https://github.com/apache/incubator-nuttx/pull/4455#issuecomment-910464159
Ah I see. So the issue is between `clean_context` and `subdir_distclean`.
Please update tools/Makefile.win as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org