You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/24 21:45:00 UTC
[jira] [Work logged] (GOBBLIN-1769) Reduce noisy log for event reporter
[ https://issues.apache.org/jira/browse/GOBBLIN-1769?focusedWorklogId=841452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841452 ]
ASF GitHub Bot logged work on GOBBLIN-1769:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/23 21:44
Start Date: 24/Jan/23 21:44
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3629:
URL: https://github.com/apache/gobblin/pull/3629
…ull to debug
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1769
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
When reporting GobblinTrackingEvents, for large jobs they emit a larger number of events. This causes the following line to be emitted continuously:
```
log.info("Trigger immediate run to report the event since queue is almost full");
```
This log is not very useful to end users as it was originally created to debug emitting of GTE.
This PR changes the log to become a debug log.
The import changes are due to the old imports not conforming to the Gobblin Code style guide that is published https://gobblin.apache.org/docs/developer-guide/CodingStyle/
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 841452)
Remaining Estimate: 0h
Time Spent: 10m
> Reduce noisy log for event reporter
> -----------------------------------
>
> Key: GOBBLIN-1769
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1769
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When reporting GobblinTrackingEvents, for large jobs they emit a larger number of events. This causes the following line to be emitted continuously:
> {code:java}
> log.info("Trigger immediate run to report the event since queue is almost full"); {code}
> This log is not very useful to end users as it was originally created to debug emitting of GTE.
> We should set this log to be a debug log to prevent cluttering up the logs of large jobs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)