You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "yew1eb (via GitHub)" <gi...@apache.org> on 2025/11/29 13:36:21 UTC

[PR] [AURON #1674] Fix: route Upper to Spark_StringUpper and add tests [auron]

yew1eb opened a new pull request, #1675:
URL: https://github.com/apache/auron/pull/1675

    
   # Which issue does this PR close?
   
   
   Closes #1674 .
   
    # Rationale for this change
   Upper was incorrectly wired to the Lower implementation in `NativeConverters`, causing lowercase output. Correct wiring restores expected uppercase behavior.  
   
   # What changes are included in this PR?
   
   # Are there any user-facing changes?
   Yes. UPPER(...) now returns uppercase as expected.
   
   
   # How was this patch tested?
   unit tests. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AURON #1674] Fix: route Upper to Spark_StringUpper [auron]

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1675:
URL: https://github.com/apache/auron/pull/1675#discussion_r2575535424


##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -866,7 +853,7 @@ object NativeConverters extends Logging {
         buildExtScalarFunction("Spark_StringLower", e.children, e.dataType)
       case e: Upper
           if sparkAuronConfig.getBoolean(SparkAuronConfiguration.CASE_CONVERT_FUNCTIONS_ENABLE) =>
-        buildExtScalarFunction("Spark_StringLower", e.children, e.dataType)
+        buildExtScalarFunction("Spark_StringUpper", e.children, e.dataType)

Review Comment:
   caused by  https://github.com/apache/auron/pull/1614



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [AURON #1674] Fix: route Upper to Spark_StringUpper [auron]

Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 merged PR #1675:
URL: https://github.com/apache/auron/pull/1675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org