You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/29 10:01:01 UTC

[GitHub] [incubator-shardingsphere] gongsiran opened a new pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

gongsiran opened a new pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531
 
 
   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
   -
   -
   -
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r386077265
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -82,4 +91,65 @@ public void onChange(final DataChangedEvent dataChangedEvent) {
         assertThat(changeEvent.getValue(), is("value3"));
         assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
     }
+
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        when(openApiWrapper.getValue(eq("test.nonExistentKey"))).thenReturn(null);
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+
 
 Review comment:
   Keep four blank characters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl merged pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl removed a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-593200266
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931755
 
 
   ## Pull Request Test Coverage Report for [Build 9991](https://coveralls.io/builds/29098225)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage remained the same at **57.804%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29098225/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29098225/badge)](https://coveralls.io/builds/29098225) |
   | :-- | --: |
   | Change from base [Build 976](https://coveralls.io/builds/29097004): |  0.0% |
   | Covered Lines: | 10396 |
   | Relevant Lines: | 17985 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387464779
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
 
 Review comment:
   I suggest this method rename `assertWatchUpdateChangedTypeWithExistedKey`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387433812
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        assertWatchUpdateChangedType("/test/children/1", "newValue1");
+        assertThat(configCenterRepository.get("/test/children/1"), is("newValue1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
         final SettableFuture<DataChangedEvent> future = SettableFuture.create();
-        configCenterRepository.watch("/test/children/1", future::set);
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+    
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
         embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "value3");
         DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
         assertThat(changeEvent.getKey(), is("/test/children/1"));
-        assertThat(changeEvent.getValue(), is("value3"));
+        assertNull(changeEvent.getValue());
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.DELETED));
+        assertNull(configCenterRepository.get("/test/children/1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchAddChangedType() {
+        assertWatchUpdateChangedType("/test/children/newKey", "newVaule");
+    }
+    
+    @SneakyThrows
+    private void assertWatchUpdateChangedType(final String key, final String newVaule) {
+        final SettableFuture<DataChangedEvent> future = SettableFuture.create();
+        configCenterRepository.watch(key, new DataChangedEventListener() {
+        
 
 Review comment:
   Keep this line's blank character with `@Override`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387432565
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        assertWatchUpdateChangedType("/test/children/1", "newValue1");
+        assertThat(configCenterRepository.get("/test/children/1"), is("newValue1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
         final SettableFuture<DataChangedEvent> future = SettableFuture.create();
-        configCenterRepository.watch("/test/children/1", future::set);
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+    
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
         embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "value3");
 
 Review comment:
   Why delete the property and then add it right now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931755
 
 
   ## Pull Request Test Coverage Report for [Build 9945](https://coveralls.io/builds/29064846)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage remained the same at **58.145%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29064846/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29064846/badge)](https://coveralls.io/builds/29064846) |
   | :-- | --: |
   | Change from base [Build 968](https://coveralls.io/builds/29062566): |  0.0% |
   | Covered Lines: | 10533 |
   | Relevant Lines: | 18115 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387433353
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        assertWatchUpdateChangedType("/test/children/1", "newValue1");
+        assertThat(configCenterRepository.get("/test/children/1"), is("newValue1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
         final SettableFuture<DataChangedEvent> future = SettableFuture.create();
-        configCenterRepository.watch("/test/children/1", future::set);
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+    
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
         embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "value3");
         DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
         assertThat(changeEvent.getKey(), is("/test/children/1"));
-        assertThat(changeEvent.getValue(), is("value3"));
+        assertNull(changeEvent.getValue());
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.DELETED));
+        assertNull(configCenterRepository.get("/test/children/1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchAddChangedType() {
+        assertWatchUpdateChangedType("/test/children/newKey", "newVaule");
 
 Review comment:
   It's not a good idea for using `assertWatchUpdateChangedType ` method  at `assertWatchAddChangedType ` method, maybe we should rename these methods and make them more meaningful.
   
   I suggest this method rename `assertWatchUpdateChangedTypeWithNewKey`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r386077049
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -82,4 +91,65 @@ public void onChange(final DataChangedEvent dataChangedEvent) {
         assertThat(changeEvent.getValue(), is("value3"));
         assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
     }
+
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        when(openApiWrapper.getValue(eq("test.nonExistentKey"))).thenReturn(null);
 
 Review comment:
   If assert null, we can assert directly, no need `when ... thenReturn`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-593200266
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387433353
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        assertWatchUpdateChangedType("/test/children/1", "newValue1");
+        assertThat(configCenterRepository.get("/test/children/1"), is("newValue1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
         final SettableFuture<DataChangedEvent> future = SettableFuture.create();
-        configCenterRepository.watch("/test/children/1", future::set);
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+    
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
         embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "value3");
         DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
         assertThat(changeEvent.getKey(), is("/test/children/1"));
-        assertThat(changeEvent.getValue(), is("value3"));
+        assertNull(changeEvent.getValue());
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.DELETED));
+        assertNull(configCenterRepository.get("/test/children/1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchAddChangedType() {
+        assertWatchUpdateChangedType("/test/children/newKey", "newVaule");
 
 Review comment:
   It's not a good idea for using `assertWatchUpdateChangedType ` method  at `assertWatchAddChangedType ` method, maybe we should rename these methods and make them more meaningful.
   
   I suggest this method rename `assertWatchUpdateChangedTypeWithNotExistedKey`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931448
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=h1) Report
   > Merging [#4531](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/1564c630ab57a78c1e04792d862e5539aa95f2ee?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4531      +/-   ##
   ============================================
   + Coverage     55.17%   55.18%   +0.01%     
     Complexity      331      331              
   ============================================
     Files           954      954              
     Lines         17960    17960              
     Branches       3397     3397              
   ============================================
   + Hits           9909     9911       +2     
   + Misses         7418     7417       -1     
   + Partials        633      632       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `59.45% <0%> (+5.4%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=footer). Last update [1564c63...556dc52](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4531?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] gongsiran commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

gongsiran commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r386087423
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -82,4 +91,65 @@ public void onChange(final DataChangedEvent dataChangedEvent) {
         assertThat(changeEvent.getValue(), is("value3"));
         assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
     }
+
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        when(openApiWrapper.getValue(eq("test.nonExistentKey"))).thenReturn(null);
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        final SettableFuture<DataChangedEvent> future = SettableFuture.create();
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "newValue1");
+        DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
+        assertThat(changeEvent.getKey(), is("/test/children/1"));
+        assertThat(changeEvent.getValue(), is("newValue1"));
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
+    }
+
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
+        final SettableFuture<DataChangedEvent> future = SettableFuture.create();
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
+        DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
+        assertThat(changeEvent.getKey(), is("/test/children/1"));
+        assertNull(changeEvent.getValue());
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.DELETED));
 
 Review comment:
   we not support   delete ，but can  add dataChangedEventListener 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387433353
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        assertWatchUpdateChangedType("/test/children/1", "newValue1");
+        assertThat(configCenterRepository.get("/test/children/1"), is("newValue1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
         final SettableFuture<DataChangedEvent> future = SettableFuture.create();
-        configCenterRepository.watch("/test/children/1", future::set);
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+    
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
         embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "value3");
         DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
         assertThat(changeEvent.getKey(), is("/test/children/1"));
-        assertThat(changeEvent.getValue(), is("value3"));
+        assertNull(changeEvent.getValue());
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.DELETED));
+        assertNull(configCenterRepository.get("/test/children/1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchAddChangedType() {
+        assertWatchUpdateChangedType("/test/children/newKey", "newVaule");
 
 Review comment:
   It's not a good idea for using `assertWatchUpdateChangedType ` method  at `assertWatchAddChangedType ` method, maybe we should rename these methods and make them more meaningful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

tuohai666 commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-593364683
 
 
   /run ci

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931755
 
 
   ## Pull Request Test Coverage Report for [Build 48](https://coveralls.io/builds/29071536)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **122** unchanged lines in **36** files lost coverage.
   * Overall coverage increased (+**0.3%**) to **58.405%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/DescribeStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FDescribeStatement.java#L30) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowCreateTableStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowCreateTableStatement.java#L30) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dcl/DenyUserStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdcl%2FDenyUserStatement.java#L29) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/AlterIndexStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FAlterIndexStatement.java#L31) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/CreateIndexStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FCreateIndexStatement.java#L31) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/ddl/DropIndexStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fddl%2FDropIndexStatement.java#L34) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowColumnsStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowColumnsStatement.java#L32) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/ShowIndexStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdal%2Fdialect%2Fmysql%2FShowIndexStatement.java#L32) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dcl/GrantStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdcl%2FGrantStatement.java#L30) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dcl/RevokeStatement.java](https://coveralls.io/builds/29071536/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdcl%2FRevokeStatement.java#L30) | 2 | 0% |
   <!-- | **Total:** | **122** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29071536/badge)](https://coveralls.io/builds/29071536) |
   | :-- | --: |
   | Change from base [Build 968](https://coveralls.io/builds/29062566): |  0.3% |
   | Covered Lines: | 10524 |
   | Relevant Lines: | 18019 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r386077410
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -82,4 +91,65 @@ public void onChange(final DataChangedEvent dataChangedEvent) {
         assertThat(changeEvent.getValue(), is("value3"));
         assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
     }
+
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        when(openApiWrapper.getValue(eq("test.nonExistentKey"))).thenReturn(null);
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        final SettableFuture<DataChangedEvent> future = SettableFuture.create();
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "newValue1");
+        DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
+        assertThat(changeEvent.getKey(), is("/test/children/1"));
+        assertThat(changeEvent.getValue(), is("newValue1"));
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
+    }
+
 
 Review comment:
   Keep four blank characters. Please check every method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

kimmking commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r386080810
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -82,4 +91,65 @@ public void onChange(final DataChangedEvent dataChangedEvent) {
         assertThat(changeEvent.getValue(), is("value3"));
         assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
     }
+
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        when(openApiWrapper.getValue(eq("test.nonExistentKey"))).thenReturn(null);
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        final SettableFuture<DataChangedEvent> future = SettableFuture.create();
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.addOrModifyProperty("orchestration", "test.children.1", "newValue1");
+        DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
+        assertThat(changeEvent.getKey(), is("/test/children/1"));
+        assertThat(changeEvent.getValue(), is("newValue1"));
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.UPDATED));
+    }
+
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
+        final SettableFuture<DataChangedEvent> future = SettableFuture.create();
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+
+            @Override
+            public void onChange(final DataChangedEvent dataChangedEvent) {
+                future.set(dataChangedEvent);
+            }
+        });
+        embeddedApollo.deleteProperty("orchestration", "test.children.1");
+        DataChangedEvent changeEvent = future.get(5, TimeUnit.SECONDS);
+        assertThat(changeEvent.getKey(), is("/test/children/1"));
+        assertNull(changeEvent.getValue());
+        assertThat(changeEvent.getChangedType(), is(DataChangedEvent.ChangedType.DELETED));
 
 Review comment:
   now we support delete?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r387433771
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -67,12 +78,62 @@ public void assertGet() {
     @Test
     @SneakyThrows
     public void assertWatch() {
+        assertWatchUpdateChangedType("/test/children/1", "value3");
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertGetWithNonExistentKey() {
+        assertNull(configCenterRepository.get("/test/nonExistentKey"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertUpdate() {
+        assertWatchUpdateChangedType("/test/children/1", "newValue1");
+        assertThat(configCenterRepository.get("/test/children/1"), is("newValue1"));
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertWatchDeletedChangedType() {
         final SettableFuture<DataChangedEvent> future = SettableFuture.create();
-        configCenterRepository.watch("/test/children/1", future::set);
+        configCenterRepository.watch("/test/children/1", new DataChangedEventListener() {
+    
 
 Review comment:
   Keep this line's blank character with `@Override`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931755
 
 
   ## Pull Request Test Coverage Report for [Build 10003](https://coveralls.io/builds/29118708)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.006%**) to **57.804%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29118708/badge)](https://coveralls.io/builds/29118708) |
   | :-- | --: |
   | Change from base [Build 10001](https://coveralls.io/builds/29118221): |  0.006% |
   | Covered Lines: | 10396 |
   | Relevant Lines: | 17985 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#issuecomment-592931755
 
 
   ## Pull Request Test Coverage Report for [Build 9881](https://coveralls.io/builds/29045128)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage remained the same at **58.764%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29045128/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29045128/badge)](https://coveralls.io/builds/29045128) |
   | :-- | --: |
   | Change from base [Build 953](https://coveralls.io/builds/29044789): |  0.0% |
   | Covered Lines: | 10554 |
   | Relevant Lines: | 17960 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451

Posted by GitBox <gi...@apache.org>.

dongzl commented on a change in pull request #4531: Add unit test case for sharding-orchestration-center-apollo module #4451
URL: https://github.com/apache/incubator-shardingsphere/pull/4531#discussion_r386076963
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/test/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstanceTest.java
 ##########
 @@ -46,18 +51,22 @@
     
     @ClassRule
     public static EmbeddedApollo embeddedApollo = new EmbeddedApollo();
-    
 
 Review comment:
   Please keep the blank character.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services