You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "galen-pivotal (GitHub)" <gi...@apache.org> on 2018/10/01 19:25:36 UTC
[GitHub] [geode] galen-pivotal opened pull request #2546: GEODE-5800:
remove redundant casts for `DataSerializer.readObject()`
and remove unused methods on `InternalDataSerializer`.
[ Full content available at: https://github.com/apache/geode/pull/2546 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] galen-pivotal commented on issue #2546: GEODE-5800:
remove redundant casts for `DataSerializer.readObject()`
Posted by "galen-pivotal (GitHub)" <gi...@apache.org>.
I'm going to close this until I have more time to devote to cleaning up tests, etc. around this.
[ Full content available at: https://github.com/apache/geode/pull/2546 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2546: GEODE-5800:
remove redundant casts for `DataSerializer.readObject()`
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
+1 for code cleanup, obviously pending merge conflict resolution and failed test examination. I'm not confident in how `AnalyzeSerializablesJUnitTest` desire to not break backwards compatibility works in practice.
It also looks like we've let this PR get stale enough that the test failures are a bit strange. It looks like `StressNewTest` failures were `UnitTest` failures, but didn't fail in `Build`. But `Build` has been replaced by a dedicated `UnitTest` job in these past three weeks. Still, somewhat concerning that the stress went red where the `Build` didn't.
[ Full content available at: https://github.com/apache/geode/pull/2546 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] galen-pivotal commented on issue #2546: GEODE-5800:
remove redundant casts for `DataSerializer.readObject()`
Posted by "galen-pivotal (GitHub)" <gi...@apache.org>.
I was waiting on GEODE-6036 (#2997) before fixing sanctioned serializables. I haven't pushed that up yet but will in a minute.
[ Full content available at: https://github.com/apache/geode/pull/2546 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on issue #2546:
GEODE-5800: remove redundant casts for `DataSerializer.readObject()`
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
@galen-pivotal What you waiting for to merge this change?
[ Full content available at: https://github.com/apache/geode/pull/2546 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] galen-pivotal closed pull request #2546: GEODE-5800:
remove redundant casts for `DataSerializer.readObject()`
Posted by "galen-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by galen-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2546 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org