You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by jacobwil <gi...@git.apache.org> on 2016/07/20 21:56:03 UTC
[GitHub] incubator-pirk pull request #15: Bring GoogleCaliperBenchmarks branch up to ...
GitHub user jacobwil opened a pull request:
https://github.com/apache/incubator-pirk/pull/15
Bring GoogleCaliperBenchmarks branch up to date
Still not sure if this is necessarily better for us to use than JMH.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacobwil/incubator-pirk GoogleCaliperBenchmarks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 0afc8836907f9dba8a1f79aea89d4896797cf8c9
Author: Jacob <gi...@jacobwilder.org>
Date: 2016-07-20T19:49:20Z
This looks approximately correct and it compiles successfully. Haven't figured out how to run it yet though...
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #15: Bring GoogleCaliperBenchmarks into master
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/15
> I wouldn't accept this pull request just yet. Try it out
Consider changing the title of the PR to start "[WIP]" to indicate it is a work in progress. Then you can change it to a JIRA issue identifier, etc. when you are happy with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #15: [PIRK-7] [WIP] Replace JMH with Google Cali...
Posted by jacobwil <gi...@git.apache.org>.
Github user jacobwil closed the pull request at:
https://github.com/apache/incubator-pirk/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #15: [PIRK-7] [WIP] Replace JMH with Google Caliper
Posted by jacobwil <gi...@git.apache.org>.
Github user jacobwil commented on the issue:
https://github.com/apache/incubator-pirk/pull/15
We are going to continue to use JMH for now. My justification shared [on the mailing list](http://mail-archives.apache.org/mod_mbox/incubator-pirk-dev/201607.mbox/%3cCAD637oNk_P7he14RtAYpN6X=izH8rUr5kSWFa5emvJRpfGDneA@mail.gmail.com%3e) is:
> I'll put forward my vote that we stick with JMH and separate out any
benchmarks that depend on it if/when we distribute binary artifacts. JMH
seems to be better maintained (starting from the fact that it's possible to
use it without needing to modify what you get from the source repo) and it
seems to be easier to use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---