[GitHub] [flink] zhuzhurk commented on a diff in pull request #20003: [FLINK-28080][runtime] Introduce MutableURLClassLoader as parent class of FlinkUserClassLoader and SafetyNetWrapperClassLoader

[GitBox <gi...@apache.org>]

zhuzhurk commented on code in PR #20003:
URL: https://github.com/apache/flink/pull/20003#discussion_r907262950


##########
flink-core/src/main/java/org/apache/flink/util/FlinkUserCodeClassLoaders.java:
##########
@@ -131,8 +130,8 @@ public static class ParentFirstClassLoader extends FlinkUserCodeClassLoader {
      * delegate is nulled and can be garbage collected. Additional class resolution will be resolved
      * solely through the bootstrap classloader and most likely result in ClassNotFound exceptions.
      */
-    @Internal
-    public static class SafetyNetWrapperClassLoader extends URLClassLoader implements Closeable {
+    private static class SafetyNetWrapperClassLoader extends MutableURLClassLoader

Review Comment:
   No need to `implements Closeable` because `URLClassLoader` already `implements Closeable`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org