[GitHub] [helix] qqu0127 commented on a diff in pull request #2328: Multi Implementation and Test Cases

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2328:
URL: https://github.com/apache/helix/pull/2328#discussion_r1061711963


##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiInMultiZk.java:
##########
@@ -63,6 +63,7 @@ public void beforeClass() throws Exception {
                 System.out.println(elm);
             }
         }
+        System.out.println("end start");

Review Comment:
   Can we remove this?



##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -72,7 +78,7 @@
  * cluster-Zk realm routing information.
  * This test verifies that all Helix Java APIs work as expected.
  */
-public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
+public abstract class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {

Review Comment:
   has this been resolved yet?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org