You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Julian Sinai (JIRA)" <ji...@apache.org> on 2010/08/05 21:01:26 UTC

[jira] Created: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Ajax updates don't happen for FormComponents that are children of Fragments
---------------------------------------------------------------------------

                 Key: WICKET-2973
                 URL: https://issues.apache.org/jira/browse/WICKET-2973
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4.9, 1.4.8, 1.4.7, 1.4.6, 1.4.5, 1.4.4, 1.4.3, 1.4.2, 1.4.1
            Reporter: Julian Sinai


See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sinai closed WICKET-2973.
--------------------------------


Thanks very much for looking into this. You are correct, and replacing wicket:container with div was the solution.

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>            Assignee: Martin Grigorov
>         Attachments: patch.txt, quickstart.zip
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sinai updated WICKET-2973:
---------------------------------

    Attachment:     (was: quickstart.zip)

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-2973.
-------------------------------------

    Resolution: Not A Problem

The Ajax debug window shows:
ERROR: Wicket.Ajax.Call.processComponent: Component with id [[fieldfragmenta]] a was not found while trying to perform markup update. Make sure you called component.setOutputMarkupId(true) on the component whose markup you are trying to update.
INFO: Response processed successfully.

That's because you use <wicket:container> as parent. Replacing it with <div> fixes the problem. 
Please re-open the ticket if you think this is not correct.

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>            Assignee: Martin Grigorov
>         Attachments: patch.txt, quickstart.zip
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896075#action_12896075 ] 

Julian Sinai edited comment on WICKET-2973 at 8/6/10 1:17 PM:
--------------------------------------------------------------

My apologies; the problem I described in the quickstart project is bogus. I fixed it, so I removed the quickstart I previously attached.

However, I verified that my patch does fix the problem in my real codebase. I cannot reproduce it in a quickstart project yet.

      was (Author: jsinai):
    My apologies; the problem I described in the quickstart project is bogus. I fixed it.
But I verified that my patch does fix the problem in my real codebase. I cannot reproduce it in a quickstart project yet.
  
> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sinai updated WICKET-2973:
---------------------------------

    Attachment: quickstart.zip

When you run the app, the home page will have two checkboxes, One and Two.

Click One; you'll see Two gets checked because One has an onclick handler that sets the value of Two to the same as One. You'll see this printed out:

before: one=true,  two=false
after: one=true,  two=true

Click One again; you'll see Two DOES NOT get unchecked as expected, even though the printout is correct:
before: one=false,  two=true
after: one=false,  two=false



> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt, quickstart.zip
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sinai updated WICKET-2973:
---------------------------------

    Attachment: patch.txt

A patch that fixes the problem for me.

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sinai updated WICKET-2973:
---------------------------------

    Comment: was deleted

(was: When you run the app, the home page will have two checkboxes, One and Two.

Click One; you'll see Two gets checked because One has an onclick handler that sets the value of Two to the same as One. You'll see this printed out:

before: one=true,  two=false
after: one=true,  two=true

Click One again; you'll see Two DOES NOT get unchecked as expected, even though the printout is correct:
before: one=false,  two=true
after: one=false,  two=false

)

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896075#action_12896075 ] 

Julian Sinai edited comment on WICKET-2973 at 8/6/10 1:16 PM:
--------------------------------------------------------------

My apologies; the problem I described in the quickstart project is bogus. I fixed it.
But I verified that my patch does fix the problem in my real codebase. I cannot reproduce it in a quickstart project yet.

      was (Author: jsinai):
    My apologies; the problem I described in the quickstart project is real, but my patch does not fix it. It's a different problem. But I verified that my patch does fix the problem in my real codebase.
  
> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-2973:
---------------------------------------

    Assignee: Martin Grigorov

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>            Assignee: Martin Grigorov
>         Attachments: patch.txt, quickstart.zip
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895768#action_12895768 ] 

Martin Grigorov commented on WICKET-2973:
-----------------------------------------

This check was added there to prevent re-rendering of a component which parent is also added for re-rendering.
I.e. the fragment (the child in this case) should be re-rendered as part of its re-rendered parent.
Can you please create a quickstart application and attach it here so we can check what is wrong ?
Thanks!


> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sinai updated WICKET-2973:
---------------------------------

    Attachment: quickstart.zip

A new quickstart that properly demonstrates the problem this time. My patch fixes it.

When you run the app, the home page will have two checkboxes, One and Two.

Click One; you'll see Two gets checked and disabled because One has an onclick handler that sets the value of Two to the same as One, and sets the enabled flag of Two to the opposite of the value of One. You'll see this printed out:

before: one=true,  two=false,  is two enabled=true
after: one=true,  two=true,  is two enabled=false

Click One again; you'll see Two DOES NOT get unchecked or enabled as expected, even though the printout is correct:

before: one=false,  two=true,  is two enabled=false
after: one=false,  two=false,  is two enabled=true



> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt, quickstart.zip
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-2973) Ajax updates don't happen for FormComponents that are children of Fragments

Posted by "Julian Sinai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896075#action_12896075 ] 

Julian Sinai commented on WICKET-2973:
--------------------------------------

My apologies; the problem I described in the quickstart project is real, but my patch does not fix it. It's a different problem. But I verified that my patch does fix the problem in my real codebase.

> Ajax updates don't happen for FormComponents that are children of Fragments
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-2973
>                 URL: https://issues.apache.org/jira/browse/WICKET-2973
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9
>            Reporter: Julian Sinai
>         Attachments: patch.txt, quickstart.zip
>
>
> See http://apache-wicket.1842946.n4.nabble.com/refreshing-fragment-td2286189.html#a2286189

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.