You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/10 15:37:06 UTC
[GitHub] [airflow] potiuk commented on pull request #19508: :bug: (BigQueryHook) fix compatibility with sqlalchemy engine
potiuk commented on pull request #19508:
URL: https://github.com/apache/airflow/pull/19508#issuecomment-965421973
I think the change is good - but it woudl be simply great if you add simple test for that. Similar to this one: https://github.com/apache/airflow/blob/f8a6cbb3ac6bfb9a3c89c8a49d76a78e78af0430/tests/models/test_connection.py#L585 but in the "tests/providers/google/cloud/hooks/test_bigquery.py"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org