[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5568: HDFS-16653.Add error message for maxEvictableMmapedSize related Precondition check suite.

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5568:
URL: https://github.com/apache/hadoop/pull/5568#discussion_r1192839897


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java:
##########
@@ -379,13 +380,18 @@ public static ShortCircuitCache fromConf(ShortCircuitConf conf) {
   public ShortCircuitCache(int maxTotalSize, long maxNonMmappedEvictableLifespanMs,
       int maxEvictableMmapedSize, long maxEvictableMmapedLifespanMs,
       long mmapRetryTimeoutMs, long staleThresholdMs, int shmInterruptCheckMs) {
-    Preconditions.checkArgument(maxTotalSize >= 0);
+    Preconditions.checkArgument(maxTotalSize >= 0,
+      "Invalid argument: maxTotalSize must be greater than zero.");

Review Comment:
   No need to put Invalid Argument:, It will throw IllegalArgumentException, that is indicative. just keep the message post Invalid argument: in all the Preconditions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org