You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Erik Meade <em...@geekfarm.org> on 2000/11/10 06:42:36 UTC
[PATCH] Jar patch
A patch to make the Jar task throw a BuildException if
the manifest file doesn't exist rather than file not
found in Zip. Included unit tests for Jar.
--
Erik Meade emeade@objectmentor.com
Senior Consultant Object Mentor, Inc.
http://www.junit.org
Re: [PATCH] Jar patch
Posted by Peter Donald <do...@apache.org>.
At 03:01 28/11/00 +0100, you wrote:
>Erik Meade <em...@geekfarm.org> wrote:
>
>> Included unit tests for Jar.
>
>Erik, I had to disable test5 as it failed on my machine.
>
>It looks as if you'd rely on the order of tests (test4 must run before
>test5) and this is not portable. In my environment (IBM JDK 1.3,
>Linux, JUnit 3.2) tests seem to be called in _reverse_ alphabetical
>order. *Seem* to be called.
It is a jdk issue. 1.1 differs from 1.2 which differs from 1.3 with nabbing
methods from reflection whichs is what junit uses IIRC.
Cheers,
Pete
*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof." |
| - John Kenneth Galbraith |
*-----------------------------------------------------*
Re: [PATCH] Jar patch
Posted by Stefan Bodewig <bo...@apache.org>.
Erik Meade <em...@geekfarm.org> wrote:
> Included unit tests for Jar.
Erik, I had to disable test5 as it failed on my machine.
It looks as if you'd rely on the order of tests (test4 must run before
test5) and this is not portable. In my environment (IBM JDK 1.3,
Linux, JUnit 3.2) tests seem to be called in _reverse_ alphabetical
order. *Seem* to be called.
Stefan
RE: [PATCH] Jar patch
Posted by Erik Meade <em...@geekfarm.org>.
I removed the UnknownElement patch, which was changed
and resubmitted separately.
> > -----Original Message-----
> > From: Erik Meade [mailto:emeade@geekfarm.org]
> > Sent: Thursday, November 09, 2000 9:43 PM
> > To: ant-dev@jakarta.apache.org
> > Subject: [PATCH] Jar patch
> >
> >
> > A patch to make the Jar task throw a BuildException if
> > the manifest file doesn't exist rather than file not
> > found in Zip. Included unit tests for Jar.
> >
> > --
> > Erik Meade emeade@objectmentor.com
> > Senior Consultant Object Mentor, Inc.
> > http://www.junit.org
> >
RE: [PATCH] Jar patch
Posted by Erik Meade <em...@geekfarm.org>.
Well I am just batting a thousand tonight...
> -----Original Message-----
> From: Erik Meade [mailto:emeade@geekfarm.org]
> Sent: Thursday, November 09, 2000 9:43 PM
> To: ant-dev@jakarta.apache.org
> Subject: [PATCH] Jar patch
>
>
> A patch to make the Jar task throw a BuildException if
> the manifest file doesn't exist rather than file not
> found in Zip. Included unit tests for Jar.
>
> --
> Erik Meade emeade@objectmentor.com
> Senior Consultant Object Mentor, Inc.
> http://www.junit.org
>