You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 10:24:49 UTC
[GitHub] [airflow] potiuk opened a new pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
potiuk opened a new pull request #22499:
URL: https://github.com/apache/airflow/pull/22499
Checking coerce_datetime presence (and also consolidating all
2.1 checks in a single pre-commit check).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22499:
URL: https://github.com/apache/airflow/pull/22499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077470234
CC: @lwyszomi -> this one will fail now so I will rebase after your PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077498462
True. That was actually a teamwork :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077470037
<img width="1201" alt="Screenshot 2022-03-24 at 11 23 01" src="https://user-images.githubusercontent.com/595491/159896173-8b31c229-272a-4bb0-a832-9342256d209b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077474940
@potiuk thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077481478
> This probably means RC2 for google provider?
Not really. This is just 2.1+ compatibility problem and it has been already released so it is not a "regression" in the new release.
BTW. It was actually me who introduced it here: https://github.com/apache/airflow/commit/372849486cd455a4ff4821b01805a442f1a78417 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077470234
@lwyszomi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077488266
@potiuk not only you 😄 #18088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077481478
> This probably means RC2 for google provider?
Not really. This is just 2.1+ compatibility problem and it has been already released so it is not a "regression" in the new release.
BTW. It was actually me who introduce it here: https://github.com/apache/airflow/commit/372849486cd455a4ff4821b01805a442f1a78417 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077476660
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #22499: Add check for coerce_datetime to Airflow 2-1 compatibility check
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22499:
URL: https://github.com/apache/airflow/pull/22499#issuecomment-1077474364
This probably means RC2 for google provider?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org