[GitHub] [pinot] ddcprg commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API

[GitBox <gi...@apache.org>]

ddcprg commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-947973700


   @siddharthteotia there will be incompatibilities. I was thinking whether a new config property could be introduced to select the compatibility mode so existing queries can still work with Joda formats and eventually migrated to use Java formats if needed, I'm not sure how easy introducing the setting would be as I'm still not very familiar with the code and I can see all thee methods are static.
   
   With regards to other types, they are supported in Java with slightly different names: a Timestamp is an Instant and and Instant can be timezoned to convert it into a ZonedDateTime. Intervals are represented with Period and Duration.
   
   I will edit the PR description to include more details later on


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org