You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/26 17:02:03 UTC
[GitHub] [incubator-mxnet] akarbown opened a new pull request #19428: [BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
akarbown opened a new pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428
## Description ##
It's the change (#19299) ported form mxnet 1.7.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] akarbown commented on pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
akarbown commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-718748707
@mxnet-bot run ci [unix-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-718911711
Thanks @akarbown for creating #19445 on v1.x too!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-718748753
Jenkins CI successfully triggered : [unix-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TaoLv commented on pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-718381084
@samskalicky Do you want to confirm this is needed for the release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] akarbown commented on pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
akarbown commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-718509824
> Bug fixes are still ok until we finish the license issues.
>
> Can someone confirm this fix has already been ported to the 1.x branch already before we merge this?
I'll create PR with that fix for 1.x today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19428: [BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-716689276
Hey @akarbown , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, windows-gpu, sanity, unix-gpu, centos-gpu, website, clang, centos-cpu, miscellaneous, unix-cpu, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19428: [BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-717065683
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] akarbown commented on pull request #19428: [BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
akarbown commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-717065632
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #19428: [v1.8.x][BUGFIX] Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19428:
URL: https://github.com/apache/incubator-mxnet/pull/19428#issuecomment-718454306
Bug fixes are still ok until we finish the license issues.
Can someone confirm this fix has already been ported to the 1.x branch already before we merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org