You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ba...@apache.org on 2010/06/09 00:13:37 UTC

svn commit: r952844 - /james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/DKIMVerifier.java

Author: bago
Date: Tue Jun  8 22:13:37 2010
New Revision: 952844

URL: http://svn.apache.org/viewvc?rev=952844&view=rev
Log:
Remove System.outs from default verification method (JDKIM-14).

Modified:
    james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/DKIMVerifier.java

Modified: james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/DKIMVerifier.java
URL: http://svn.apache.org/viewvc/james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/DKIMVerifier.java?rev=952844&r1=952843&r2=952844&view=diff
==============================================================================
--- james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/DKIMVerifier.java (original)
+++ james/jdkim/trunk/main/src/main/java/org/apache/james/jdkim/DKIMVerifier.java Tue Jun  8 22:13:37 2010
@@ -351,8 +351,9 @@ public class DKIMVerifier extends DKIMCo
         if (verifiedSignatures.size() == 0) {
             throw prepareException(signatureExceptions);
         } else {
-            // TODO list good and bad signatures.
-            // remove system out.
+            // There is no access to the signatureExceptions when
+            // there is at least one valid signature (JDKIM-14)
+            /*
             for (Iterator i = signatureExceptions.keySet().iterator(); i
                     .hasNext();) {
                 String f = (String) i.next();
@@ -360,10 +361,13 @@ public class DKIMVerifier extends DKIMCo
                         + ((FailException) signatureExceptions.get(f))
                                 .getMessage() + " FIELD: " + f);
             }
+            */
+            /*
             for (Iterator i = verifiedSignatures.iterator(); i.hasNext();) {
                 SignatureRecord sr = (SignatureRecord) i.next();
                 System.out.println("DKIM-Pass:" + sr);
             }
+            */
             return verifiedSignatures;
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org