You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/08/10 19:32:52 UTC
Review Request 61574: Added `kill()` support to the test containerizer
interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61574/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
This is needed to make some tests pass that rely on the test
containerizer.
Diffs
-----
src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538
src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
Diff: https://reviews.apache.org/r/61574/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61574: Added `kill()` support to the test
containerizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61574/#review182996
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2017, 5:41 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61574/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 5:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is needed to make some tests pass that rely on the test
> containerizer.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538
> src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
>
>
> Diff: https://reviews.apache.org/r/61574/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61574: Added `kill()` support to the test
containerizer interface.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61574/
-----------------------------------------------------------
(Updated Aug. 15, 2017, 5:41 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated review deps
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
This is needed to make some tests pass that rely on the test
containerizer.
Diffs (updated)
-----
src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538
src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
Diff: https://reviews.apache.org/r/61574/diff/3/
Changes: https://reviews.apache.org/r/61574/diff/2-3/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61574: Added `kill()` support to the test
containerizer interface.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61574/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 11:11 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
This is needed to make some tests pass that rely on the test
containerizer.
Diffs (updated)
-----
src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538
src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
Diff: https://reviews.apache.org/r/61574/diff/2/
Changes: https://reviews.apache.org/r/61574/diff/1-2/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61574: Added `kill()` support to the test
containerizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61574/#review182904
-----------------------------------------------------------
src/tests/containerizer.hpp
Lines 168 (patched)
<https://reviews.apache.org/r/61574/#comment258847>
s/status/signal/
src/tests/containerizer.cpp
Lines 534-541 (patched)
<https://reviews.apache.org/r/61574/#comment258848>
Can you do this inside `TestContainerizerProcess::kill` instead of here? Seems more consistent with how we handled `attach` for example.
- Vinod Kone
On Aug. 10, 2017, 7:32 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61574/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 7:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is needed to make some tests pass that rely on the test
> containerizer.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp 4bd40c32625bc1f7998d523c6ee81bf78ac74538
> src/tests/containerizer.cpp 1d2b6391cf7a7545fa44206c59d05764f3e8cdfb
>
>
> Diff: https://reviews.apache.org/r/61574/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>