You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lei Xu <le...@cloudera.com> on 2017/03/28 21:42:05 UTC

Review Request 58005: SENTRY-1626. Tables contain createTime should either remove it or update the time using SQL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58005/
-----------------------------------------------------------

Review request for sentry.


Bugs: SENTRY-1626
    https://issues.apache.org/jira/browse/SENTRY-1626


Repository: sentry


Description
-------

It changes `createTimeMs` from `long` to `timestamp` type in java / jdo. And change the SQL and set the default value of it, so that this field wil be populated when the entry being inserted.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java a0d34459d 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java 476fbcb2a 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo e981bcf0f 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 6474389a1 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 1ab83432d 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 0418b298f 
  sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 68d2c8d53 


Diff: https://reviews.apache.org/r/58005/diff/1/


Testing
-------

run `mvn test` under `sentry-provider/sentry-provider-db`.


Thanks,

Lei Xu