You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/06/01 17:25:55 UTC
[GitHub] [superset] rusackas opened a new pull request, #24265: fix(capitalization): Capitalizing the 'metric' label in Pivot Tables
rusackas opened a new pull request, #24265:
URL: https://github.com/apache/superset/pull/24265
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Capitalizing the 'metric' header according to [capitalization guidelines](https://github.com/apache/superset/wiki/Capitalization-Guidelines).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
<img width="275" alt="image" src="https://github.com/apache/superset/assets/812905/749c4141-4601-4eda-9754-539b69b86a95">
After:
<img width="218" alt="image" src="https://github.com/apache/superset/assets/812905/116fc9ca-d8a5-45bf-9cca-57ad4f2e746e">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24265: fix(capitalization): Capitalizing the 'metric' label in Pivot Tables
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24265:
URL: https://github.com/apache/superset/pull/24265#issuecomment-1572518143
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24265?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24265](https://app.codecov.io/gh/apache/superset/pull/24265?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ae00092) into [master](https://app.codecov.io/gh/apache/superset/commit/f6e769ae9412cee729dd8c265c1912fd370178f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f6e769a) will **decrease** coverage by `11.08%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24265 +/- ##
===========================================
- Coverage 68.31% 57.23% -11.08%
===========================================
Files 1957 1957
Lines 75597 75596 -1
Branches 8222 8222
===========================================
- Hits 51641 43270 -8371
- Misses 21848 30218 +8370
Partials 2108 2108
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.37% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.29% <ø> (ø)` | |
| python | `59.91% <ø> (-22.91%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.42% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...s/plugin-chart-pivot-table/src/PivotTableChart.tsx](https://app.codecov.io/gh/apache/superset/pull/24265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL1Bpdm90VGFibGVDaGFydC50c3g=) | `0.00% <ø> (ø)` | |
... and [306 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24265/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #24265: fix(capitalization): Capitalizing the 'metric' label in Pivot Tables
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24265:
URL: https://github.com/apache/superset/pull/24265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org