[jira] [Commented] (TEZ-3753) Improve error message in IFile for buffer length overflow

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096814#comment-16096814 ] 

TezQA commented on TEZ-3753:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12878398/tez-3753.002.patch
  against master revision 5d78833.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2583//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/2583//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-library.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2583//console

This message is automatically generated.

> Improve error message in IFile for buffer length overflow
> ---------------------------------------------------------
>
>                 Key: TEZ-3753
>                 URL: https://issues.apache.org/jira/browse/TEZ-3753
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.1
>            Reporter: Muhammad Samir Khan
>            Assignee: Muhammad Samir Khan
>         Attachments: tez-3753.001.patch, tez-3753.002.patch
>
>
> When a record size is too big and the byte array doubling expansion crosses 2G the array size overflows and becomes negative. It would be good to fail the code paths saying record is too big so that error is easy to understand for users.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)