You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/05 03:23:55 UTC
Review Request 37109: Removed ability to mutate user from scheduler
library
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37109/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The scheduler used to mutate the user field to the os::user if it was not set. This patch removes this functionality and leaves it upto the client to provide a user as part of SUBSCRIBE.
Diffs
-----
src/examples/event_call_framework.cpp 8054068fa746f8635f1133ceac530e04eaa0e1d7
src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
Diff: https://reviews.apache.org/r/37109/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37109: Removed ability to mutate user from
scheduler library
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37109/#review94389
-----------------------------------------------------------
Ship it!
- Alexander Rojas
On Aug. 5, 2015, 3:23 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37109/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 3:23 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The scheduler used to mutate the user field to the os::user if it was not set. This patch removes this functionality and leaves it upto the client to provide a user as part of SUBSCRIBE.
>
>
> Diffs
> -----
>
> src/examples/event_call_framework.cpp 8054068fa746f8635f1133ceac530e04eaa0e1d7
> src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
>
> Diff: https://reviews.apache.org/r/37109/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37109: Removed ability to mutate user from
scheduler library
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37109/#review94230
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37109]
All tests passed.
- Mesos ReviewBot
On Aug. 5, 2015, 1:23 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37109/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 1:23 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The scheduler used to mutate the user field to the os::user if it was not set. This patch removes this functionality and leaves it upto the client to provide a user as part of SUBSCRIBE.
>
>
> Diffs
> -----
>
> src/examples/event_call_framework.cpp 8054068fa746f8635f1133ceac530e04eaa0e1d7
> src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
>
> Diff: https://reviews.apache.org/r/37109/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37109: Removed ability to mutate user from
scheduler library
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37109/#review94171
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 5, 2015, 1:23 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37109/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 1:23 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The scheduler used to mutate the user field to the os::user if it was not set. This patch removes this functionality and leaves it upto the client to provide a user as part of SUBSCRIBE.
>
>
> Diffs
> -----
>
> src/examples/event_call_framework.cpp 8054068fa746f8635f1133ceac530e04eaa0e1d7
> src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4
>
> Diff: https://reviews.apache.org/r/37109/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>