You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by me...@apache.org on 2006/12/27 08:11:42 UTC

svn commit: r490447 - in /incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server: TuscanyServer.java management/jmx/AbstractAgent.java management/jmx/RmiAgent.java

Author: meerajk
Date: Tue Dec 26 23:11:41 2006
New Revision: 490447

URL: http://svn.apache.org/viewvc?view=rev&rev=490447
Log:
refined.

Modified:
    incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/TuscanyServer.java
    incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/AbstractAgent.java
    incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/RmiAgent.java

Modified: incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/TuscanyServer.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/TuscanyServer.java?view=diff&rev=490447&r1=490446&r2=490447
==============================================================================
--- incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/TuscanyServer.java (original)
+++ incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/TuscanyServer.java Tue Dec 26 23:11:41 2006
@@ -163,7 +163,6 @@
      */
     private ClassLoader getTuscanyClassLoader(File bootDir) {
         URL[] urls = LaunchHelper.scanDirectoryForJars(bootDir);
-        System.err.println(Arrays.asList(urls));
         return new URLClassLoader(urls, getClass().getClassLoader());
     }
 

Modified: incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/AbstractAgent.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/AbstractAgent.java?view=diff&rev=490447&r1=490446&r2=490447
==============================================================================
--- incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/AbstractAgent.java (original)
+++ incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/AbstractAgent.java Tue Dec 26 23:11:41 2006
@@ -59,7 +59,7 @@
     /**
      * @see org.apache.tuscany.standalone.server.management.jmx.Agent#register(java.lang.Object, java.lang.String)
      */
-    public void register(Object instance, String name) throws ManagementException {
+    public final void register(Object instance, String name) throws ManagementException {
         
         try {
             mBeanServer.registerMBean(instance, new ObjectName(DOMAIN + ":name=" + name));
@@ -72,7 +72,7 @@
     /**
      * @see org.apache.tuscany.standalone.server.management.jmx.Agent#start()
      */
-    public void start() throws ManagementException {
+    public final void start() throws ManagementException {
 
         try {
             
@@ -80,6 +80,8 @@
                 throw new IllegalArgumentException("Agent already started");
             }
             
+            preStart();
+            
             JMXServiceURL url = getAdaptorUrl();
             connectorServer = JMXConnectorServerFactory.newJMXConnectorServer(url, null, mBeanServer);
             
@@ -98,7 +100,7 @@
     /**
      * @see org.apache.tuscany.standalone.server.management.jmx.Agent#shutdown()
      */
-    public void shutdown() throws ManagementException {
+    public final void shutdown() throws ManagementException {
         
         try {
             
@@ -107,6 +109,7 @@
             }
             
             connectorServer.stop();
+            postStop();
             started.set(false);
             
         } catch (IOException ex) {
@@ -128,5 +131,17 @@
      * @return Adaptor URL.
      */
     protected abstract JMXServiceURL getAdaptorUrl();
+    
+    /**
+     * Any initialiation required for protocol specific agent.
+     *
+     */
+    protected abstract void preStart();
+    
+    /**
+     * Any initialiation required for protocol specific agent.
+     *
+     */
+    protected abstract void postStop();
 
 }

Modified: incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/RmiAgent.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/RmiAgent.java?view=diff&rev=490447&r1=490446&r2=490447
==============================================================================
--- incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/RmiAgent.java (original)
+++ incubator/tuscany/java/sca/runtime/standalone/server.start/src/main/java/org/apache/tuscany/standalone/server/management/jmx/RmiAgent.java Tue Dec 26 23:11:41 2006
@@ -83,13 +83,13 @@
     }
 
     /**
-     * @see org.apache.tuscany.standalone.server.management.jmx.Agent#start()
+     * @see org.apache.tuscany.standalone.server.management.jmx.AbstractAgent#preStart()
      */
-    public void start() throws ManagementException {
+    @Override
+    public void preStart() throws ManagementException {
 
         try {
             registry = LocateRegistry.createRegistry(port);
-            super.start();
         } catch (RemoteException ex) {
             throw new ManagementException(ex);
         }
@@ -97,15 +97,13 @@
     }
 
     /**
-     * @see org.apache.tuscany.standalone.server.management.jmx.Agent#shutdown()
+     * @see org.apache.tuscany.standalone.server.management.jmx.AbstractAgent#postStop()
      */
-    public void shutdown() throws ManagementException {
+    @Override
+    public void postStop() throws ManagementException {
         
         try {
-            
-            super.shutdown();
-            UnicastRemoteObject.unexportObject(registry, true);
-            
+            UnicastRemoteObject.unexportObject(registry, true);            
         } catch (IOException ex) {
             throw new ManagementException(ex);
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org