[GitHub] [dubbo-go] AlexStocks commented on a diff in pull request #1833: Fix: decode net stream bytes as getty rule

[GitBox <gi...@apache.org>]

AlexStocks commented on code in PR #1833:
URL: https://github.com/apache/dubbo-go/pull/1833#discussion_r851597771


##########
protocol/dubbo/dubbo_codec.go:
##########
@@ -240,10 +249,13 @@ func (c *DubboCodec) decodeResponse(data []byte) (*remoting.Response, int, error
 	if err != nil {
 		originErr := perrors.Cause(err)
 		// if the data is very big, so the receive need much times.
-		if originErr == hessian.ErrHeaderNotEnough || originErr == hessian.ErrBodyNotEnough {
-			return nil, 0, originErr
+		if originErr == hessian.ErrHeaderNotEnough { // this is impossible, as dubbo_codec.go:DubboCodec::Decode() line 167

Review Comment:
   确定在 1.5 分支中，这个注释也是正确的么？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org