[GitHub] [cloudstack] weizhouapache commented on pull request #4283: Removes unnecessary validations

[GitBox <gi...@apache.org>]

weizhouapache commented on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-762895687


   for vms, we use "cmk find hostsformigration" to list all hosts, it also mentions if the hosts are suitable or not for migration.
   if users try to migrate vm to a unsuitable host, cloudstack still allows it.
   
   for volumes, it looks like "find storagepoolsformigration" also mark storage pools with unmatched tag as "unsuitable".
   https://github.com/apache/cloudstack/blob/master/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java#L72
   https://github.com/apache/cloudstack/blob/master/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java#L81
   https://github.com/apache/cloudstack/blob/master/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java#L105
   
   @rafaelweingartner @RodrigoDLopez  could you please confirm it ?
   if so, I think we could remove the check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org